[webkit-reviews] review granted: [Bug 40986] Change to Vertical Alignment of MathML Constructs to Use the Baseline : [Attachment 59371] Patch to change to baseline alignment.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Alex Milowski
<alex at milowski.com>'s request for review:
Bug 40986: Change to Vertical Alignment of MathML Constructs to Use the
Baseline
https://bugs.webkit.org/show_bug.cgi?id=40986

Attachment 59371: Patch to change to baseline alignment.
https://bugs.webkit.org/attachment.cgi?id=59371&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
LGTM.

165		int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
 166		 if (heightDiff < 0) 
 167		     heightDiff = 0;

maybe add a comment to when this can happen?

WebCore/mathml/RenderMathMLUnderOver.cpp:255
 +		baseline += static_cast<int>((zoomFactor > 1.25 ? 2 : 3) *
zoomFactor);
ieck :-) good that you added a FIXME at least.