[webkit-reviews] review granted: [Bug 36128] [Gtk] nameFromChildren is obsolete : [Attachment 58885] combined patch (code+test) to fix this bug

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 36128: [Gtk] nameFromChildren is obsolete
https://bugs.webkit.org/show_bug.cgi?id=36128

Attachment 58885: combined patch (code+test) to fix this bug
https://bugs.webkit.org/attachment.cgi?id=58885&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>

> @@ -1501,8 +1493,8 @@ static AtkObject*
webkit_accessible_table_get_caption(AtkTable* table)
>  static const gchar* webkit_accessible_table_get_column_description(AtkTable*
table, gint column)
>  {
>      AtkObject* columnHeader = atk_table_get_column_header(table, column);
> -    if (columnHeader)
> -	   return returnString(nameFromChildren(core(columnHeader)));
> +    if (columnHeader && ATK_IS_TEXT(columnHeader))
> +	   return webkit_accessible_text_get_text(ATK_TEXT(columnHeader), 0,
-1);
>  

> +    if (rowHeader && ATK_IS_TEXT(rowHeader))
> +	   return webkit_accessible_text_get_text(ATK_TEXT(rowHeader), 0, -1);


Can ATK_IS_TEXT check for nil, so you don't need to check for nil and
ATK_IS_TEXT?