[webkit-reviews] review granted: [Bug 40893] CLEANUP: Take care of the comments in bug 40084 : [Attachment 59380] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 11:03:09 PDT 2010


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 40893: CLEANUP: Take care of the comments in bug 40084
https://bugs.webkit.org/show_bug.cgi?id=40893

Attachment 59380: Patch
https://bugs.webkit.org/attachment.cgi?id=59380&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -FormSubmission::FormSubmission(Method method, const KURL& action, const
String& target, const String& contentType, PassRefPtr<FormState> state,
PassRefPtr<FormData> data, const String& boundary, bool lockHistory,
PassRefPtr<Event> event)

I suggest just adding the "inline" keyword in front of this constructor
definition. Since it's only used in the create function, there's no need to
move it to the header. Also, the version in the header uses formatting that is
not standard for WebKit, not indenting the member initializer list.

r=me


More information about the webkit-reviews mailing list