[webkit-reviews] review denied: [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data. : [Attachment 59308] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 40540: [chromium] Add new stubs for querying platform drag-and-drop and
copy-and-paste data.
https://bugs.webkit.org/show_bug.cgi?id=40540

Attachment 59308: Patch
https://bugs.webkit.org/attachment.cgi?id=59308&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/chromium/ChromiumBridge.h:106
 +	    static HashSet<String>
clipboardReadTypes(PasteboardPrivate::ClipboardBuffer, bool*
containsFilenames);
clipboardReadTypes might be better named clipboardGetAvailableTypes

WebKit/chromium/public/WebClipboard.h:57
 +	    BufferDrag,
It is probably worth saying something about the meaning of BufferDrag here.
Mention that it is a readonly buffer corresponding to the last drag-n-drop
operation or something like that.
WebKit/chromium/public/WebClipboard.h:77
 +	virtual WebVector<WebString> readTypes(Buffer, bool* containsFilenames)
= 0;
readTypes -> getAvailableTypes or maybe readAvailableTypes?  what does the
return value of readData indicate?  please specify.

WebKit/chromium/src/ChromiumBridge.cpp:203
 +	WebDragData dragData; // FIXME: Define the conversion from
ClipboardData to WebDragData.
this would be a good place to call notImplemented()

WebKit/chromium/src/ChromiumBridge.cpp:221
 +	WebKit::WebString resultData;
no need for the WebKit:: prefix here