[webkit-reviews] review granted: [Bug 38728] WebSocket: Add WebSocketHandshakeResponse : [Attachment 59354] Patch (Address comment #31)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 08:41:11 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 38728: WebSocket: Add WebSocketHandshakeResponse
https://bugs.webkit.org/show_bug.cgi?id=38728

Attachment 59354: Patch (Address comment #31)
https://bugs.webkit.org/attachment.cgi?id=59354&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 s.append(static_cast<UChar>(0x2026)); // U+2026 Horizontal ellipsis.

This should use a character constant from CharacterNames.h. We already have one
for ellipsis.

r=me with this change.


More information about the webkit-reviews mailing list