[webkit-reviews] review denied: [Bug 40925] Speech Input: Add a speech button to text input element (no rendering or actions yet) : [Attachment 59261] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 22 08:33:56 PDT 2010
Kent Tamura <tkent at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 40925: Speech Input: Add a speech button to text input element (no
rendering or actions yet)
https://bugs.webkit.org/show_bug.cgi?id=40925
Attachment 59261: Patch
https://bugs.webkit.org/attachment.cgi?id=59261&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
> @@ -1,5 +1,60 @@
> 2010-06-21 Satish Sampath <satish at chromium.org>
>
> + Reviewed by NOBODY (OOPS!).
This form of ChangeLog diff makes a problem with commit queue. Please change
the date of the new ChangeLog entry.
WebCore/html/HTMLInputElement.cpp:2830
+ /* FIXME: Enable the following as the renderers are updated to include
speech UI.
Do not have commented-out code.
WebCore/html/HTMLInputElement.cpp:2842
+ default:
Do not use "default" for inputType().
More information about the webkit-reviews
mailing list