[webkit-reviews] review denied: [Bug 40917] [Chromium] Add a sanity test for heap profiler : [Attachment 59251] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 22 00:43:05 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 40917: [Chromium] Add a sanity test for heap profiler
https://bugs.webkit.org/show_bug.cgi?id=40917
Attachment 59251: patch
https://bugs.webkit.org/attachment.cgi?id=59251&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/js/Tests.js:486
+ test.releaseControl();
Also return from the function, owtherwise test.fail will be called as well.
WebKit/chromium/ChangeLog:5
+ [Chromium] Add a sanity test for heap profiler.
Can you implement it as a layout test instead?
More information about the webkit-reviews
mailing list