[webkit-reviews] review denied: [Bug 40968] Make PendingScript hold a CachedResourceClient open for its lifetime : [Attachment 59340] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 23:10:57 PDT 2010


Eric Seidel <eric at webkit.org> has denied Tony Gentilcore <tonyg at chromium.org>'s
request for review:
Bug 40968: Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

Attachment 59340: Patch
https://bugs.webkit.org/attachment.cgi?id=59340&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5ScriptRunner.cpp:57
 +	if (m_parsingBlockingScript.cachedScript() &&
m_parsingBlockingScript.watchingForLoad)
I don't thin we should bother moving watchingForLoad() back to being a
direct-access member.  I suspect that PendingScript is only going to be moving
more and more towards class-ness.

I'm also not sure it maters. :)

Move the implementation stuff into the cpp, and then I think this is good to
go.


More information about the webkit-reviews mailing list