[webkit-reviews] review requested: [Bug 38429] Web Inspector: cycle through tag name / attributes / new attribute on Tab. : [Attachment 54867] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 38429: Web Inspector: cycle through tag name / attributes / new attribute
on Tab.
https://bugs.webkit.org/show_bug.cgi?id=38429

Attachment 54867: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=54867&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Adam, I don't think we should jump in and start r-ing each-others changes,
should we. Or at least please tell me that this game has started and explain
the rules so that I was prepared :) Now that Joe self-nominated to review this,
I would expect him to do r+/- when he has a minute.  You cose a strange way of
reminding him about the issue though.

Btw, please define "the front-end folks" - you must have some insight into the
state of the front-end development I am missing. Ok, enough sarcasm...

> By the way, what is the testing strategy for the inspector front-end code? 
There don't seem to be any test changes in this patch.

You are right, we don't have tests for keyboard traversal since they are tricky
to implement. In fact, we did not have tests at all a year ago. I think we are
doing fair amount of progress in adding them now.

Anyways, Joe, I am not insisting on landing this, but I did run into the
problem several times when tried adding attributes using keyboard only on
elements with > 5 existing attributes. Feel free to r- should you have
concerns. I surely can get this reviewed / landed locally, but I'd like to get
your Ok given that you've been working on keyboard traversal.