[webkit-reviews] review granted: [Bug 40645] Fragment parsing needs to go through the HTML5 Parser code path : [Attachment 59333] Updated per Adam's review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 21:38:50 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 40645: Fragment parsing needs to go through the HTML5 Parser code path
https://bugs.webkit.org/show_bug.cgi?id=40645

Attachment 59333: Updated per Adam's review comments
https://bugs.webkit.org/attachment.cgi?id=59333&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Politics aside, this is a good patch.  Thanks.	:)

LayoutTests/fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt:5
 +  FAIL: <foo<bar> parsed as <foo<bar></foo<bar> instead of
<foo><bar></bar></foo>
Can you double-check this in minefield?

WebCore/html/HTML5TreeBuilder.h:113
 +	// FIXME: FragmentScriptingPermission is a HACK for
platform/Pasteboard.
This seems a bit over the top, but ok.


More information about the webkit-reviews mailing list