[webkit-reviews] review requested: [Bug 40876] [EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp : [Attachment 59323] patch for windowRect and setWindowRect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 19:10:28 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 40876: [EFL] Implement windowRect() and setWindowRect() in
ChromeClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=40876

Attachment 59323: patch for windowRect and setWindowRect
https://bugs.webkit.org/attachment.cgi?id=59323&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Rafael, thank you for your comment. At latst, there are no style error. 

The reason I use Ecore_X_Window is to change window size. When I tested
setWindowRect() on WebKitGTK, window size was changed.
So, I need to use Ecore_X_Window in order to change window size. Of course, I
also think that windowRect() can use Ecore_Evas.
But, I used same efl object.

If I have any misunderstanding, please let me know.

Thanks.


More information about the webkit-reviews mailing list