[webkit-reviews] review denied: [Bug 38568] <input type=number> UI: Support disabled/readonly states : [Attachment 55098] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 38568: <input type=number> UI: Support disabled/readonly states
https://bugs.webkit.org/show_bug.cgi?id=38568

Attachment 55098: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55098&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Mostly questions and nits.

WebCore/rendering/TextControlInnerElements.cpp:244
 +	bool insideBox = local.x() >= 0 && local.x() < box->width() &&
local.y() >= 0 && local.y() < box->height();
Why this manual comparison instead of the contains() call you're replacing
below?

WebCore/rendering/TextControlInnerElements.cpp: 
 +		if (local.y() < renderBox()->y() + renderBox()->height() / 2)
What happened to the renderBox()->y() part of this computation?

WebCore/rendering/TextControlInnerElements.h:81
 +	virtual bool isEnabledFormControl() const { return
static_cast<Element*>(const_cast<SpinButtonElement*>(this)->shadowAncestorNode(
))->isEnabledFormControl(); }
const_cast?  We should be able to write this code without const_cast.