[webkit-reviews] review canceled: [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data. : [Attachment 59105] Patch

[bugzilla-daemon at webkit.org]

Daniel Cheng <dcheng at chromium.org> has canceled Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 40540: [chromium] Add new stubs for querying platform drag-and-drop and
copy-and-paste data.
https://bugs.webkit.org/show_bug.cgi?id=40540

Attachment 59105: Patch
https://bugs.webkit.org/attachment.cgi?id=59105&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #49)
> (From update of attachment 59105 [details])
> WebKit/chromium/public/WebDataTransfer.h:47
>  +	  virtual WebVector<WebString> types(Source, bool* containsFilenames) =
0;
> since this interface is implemented by the embedder, these methods should all

> have default implementations.
> 

Chromium patch posted at http://codereview.chromium.org/2830019.

> WebKit/chromium/public/WebKitClient.h:79
>  +	  virtual WebDataTransfer* dataTransfer() { return 0; }
> it would be very helpful if you could include some documentation
> about what WebDataTransfer is, and it is not clear to me why it
> is a global thing.  should this method be named currentDataTransfer
> to suggest that this is the information about a current data transfer
> if any exists.

Per our conversation, I've updated the patch and folded all the WebDataTransfer
stuff into WebClipboard.