[webkit-reviews] review granted: [Bug 40949] Add PluginInfoStore class : [Attachment 59301] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 40949: Add PluginInfoStore class
https://bugs.webkit.org/show_bug.cgi?id=40949

Attachment 59301: Patch
https://bugs.webkit.org/attachment.cgi?id=59301&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: WebKit2/Shared/WebPreferencesStore.h
> ===================================================================
> --- WebKit2/Shared/WebPreferencesStore.h	(revision 61578)
> +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> @@ -43,6 +43,7 @@ struct WebPreferencesStore {
>      {
>	   encoder.encode(javaScriptEnabled);
>	   encoder.encode(loadsImagesAutomatically);
> +	   encoder.encode(pluginsEnabled);
>	   encoder.encode(minimumFontSize);
>	   encoder.encode(minimumLogicalFontSize);
>	   encoder.encode(defaultFontSize);
> @@ -61,6 +62,8 @@ struct WebPreferencesStore {
>	       return false;
>	   if (!decoder.decode(s.loadsImagesAutomatically))
>	       return false;
> +	   if (!decoder.decode(s.pluginsEnabled))
> +	       return false;
>	   if (!decoder.decode(s.minimumFontSize))
>	       return false;
>	   if (!decoder.decode(s.minimumLogicalFontSize))
> @@ -86,6 +89,8 @@ struct WebPreferencesStore {
>  
>      bool javaScriptEnabled;
>      bool loadsImagesAutomatically;
> +    bool pluginsEnabled;
You should mention in your changelog that you are also making this change to
the preferences.

Otherwise, looks good. r=me.