[webkit-reviews] review granted: [Bug 40938] RetainPtr can't be used in HashMaps or HashSets : [Attachment 59283] Patch that mimics COMPtr.h's handling of hashing code.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted John Sullivan
<sullivan at apple.com>'s request for review:
Bug 40938: RetainPtr can't be used in HashMaps or HashSets
https://bugs.webkit.org/show_bug.cgi?id=40938

Attachment 59283: Patch that mimics COMPtr.h's handling of hashing code.
https://bugs.webkit.org/attachment.cgi?id=59283&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ JavaScriptCore/wtf/RetainPtr.h	(working copy)
> @@ -24,6 +24,7 @@
>  #include "TypeTraits.h"
>  #include <algorithm>
>  #include <CoreFoundation/CoreFoundation.h>
> +#include <WTF/HashTraits.h>

It looks like intra-WTF includes are supposed to use quotes and no wtf/ prefix:


#include "HashTraits.h"

r=me