[webkit-reviews] review denied: [Bug 38179] Due to ScrollView, QWebPage::setViewportSize() forces two layout of the render tree : [Attachment 56621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 12:09:02 PDT 2010


Dave Hyatt <hyatt at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 38179: Due to ScrollView, QWebPage::setViewportSize() forces two layout of
the render tree
https://bugs.webkit.org/show_bug.cgi?id=38179

Attachment 56621: Patch
https://bugs.webkit.org/attachment.cgi?id=56621&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'm not convinced these changes are right, especially the move of
updateScrollbars to after contentsResized. You need to patch
WebDynamicScrollbarsView.m on Mac as well so we keep the logic in sync. I'd
also recommend testing on Mac with the changes in place, since you may catch
bugs with these changes when running layout tests there (since it has more test
coverage).


More information about the webkit-reviews mailing list