[webkit-reviews] review requested: [Bug 40112] Database callbacks are made using the ScriptExecutionContext of the frame that owns the Database object, rather than that of the caller : [Attachment 59238] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 40112: Database callbacks are made using the ScriptExecutionContext of the
frame that owns the Database object, rather than that of the caller
https://bugs.webkit.org/show_bug.cgi?id=40112

Attachment 59238: patch
https://bugs.webkit.org/attachment.cgi?id=59238&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
It looks like all DB callbacks are currently called in the correct context; the
test I added in this patch passes in an unmodified client. I'm not 100% sure
how this happens (I would've thought that they get executed in the context in
which the DB handle is created), but I guess keeping track of the "world" in
which the callbacks are created takes care of this problem.

In any case, I think it's worth turning callbacks into ActiveDOMObjects.

It might be hard to figure out what changes have been made to
WebCoreCommon.vsprops: I only added WebCore/bindings/generic/ to the list of
include dirs.