[webkit-reviews] review denied: [Bug 39115] [Qt] QScriptEngine API should contain a newArray function : [Attachment 59133] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 00:56:11 PDT 2010


Kent Hansen <kent.hansen at nokia.com> has denied Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>'s request for review:
Bug 39115: [Qt] QScriptEngine API should contain a newArray function
https://bugs.webkit.org/show_bug.cgi?id=39115

Attachment 59133: Patch v2
https://bugs.webkit.org/attachment.cgi?id=59133&action=review

------- Additional Comments from Kent Hansen <kent.hansen at nokia.com>
Hi Caio,
Very cool that you're helping with this!
QScriptEngine::newArray(uint) should construct an array with the given length,
but without creating any elements. It should behave like described in 15.4.2.2
in ECMA-262.
You don't have to modify the C API for achieving this; constructing an empty
array and then setting the "length" property should be fine too.
That said, I think the C API would be more useful if it does what you propose.
Like Simon said, that is best done in a separate change, and it would need a
test added to JavaScriptCore/API/tests/testapi.c.
I also think prototype() and property() should be implemented separately (even
if only done partially in the first commit); there are separate bugs for that,
https://bugs.webkit.org/show_bug.cgi?id=39356 and
https://bugs.webkit.org/show_bug.cgi?id=40903.


More information about the webkit-reviews mailing list