[webkit-reviews] review denied: [Bug 23588] Add inputmode attribute support, as per XHTML Basic 1.1 : [Attachment 58455] Resubmission after addressing reviewer's comments

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 23588: Add inputmode attribute support, as per XHTML Basic 1.1
https://bugs.webkit.org/show_bug.cgi?id=23588

Attachment 58455: Resubmission after addressing reviewer's comments
https://bugs.webkit.org/attachment.cgi?id=58455&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
You need to change more files to introduce a feature flag. e.g.
*/FeatureDefines.xcconfig, features.gypi.  Bug#40878 has a good example.

WebCore/html/HTMLInputElement.idl:103
 +		     attribute [ConvertNullToNullString, Reflect] DOMString    
  inputmode;
You don't need ConvertNullToNullString anymore.  Reflect implies it.


WebCore/html/HTMLTextAreaElement.idl:56
 +		     attribute [ConvertNullToNullString, Reflect]  DOMString   
	inputmode;
ditto.

WebKitTools/ChangeLog:5
 +	    Add feature "XHTML Basic 1.1 support with ENABLE_XHTMLBASIC
Unclosed "