[webkit-reviews] review granted: [Bug 40897] Get rid of the extensionToMIME mapping in WebBasePluginPackage : [Attachment 59223] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 40897: Get rid of the extensionToMIME mapping in WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40897

Attachment 59223: Patch
https://bugs.webkit.org/attachment.cgi?id=59223&action=review

------- Additional Comments from mitz at webkit.org
> +    for (size_t i = 0; i < mimeTypes.size(); ++i) {
> +	   const MimeClassInfo& mimeClassInfo = mimeTypes[i];
> +	   
> +	   for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) {

Please don’t reuse the outer loop’s index variable.

> +- (NSString *)MIMETypeForExtension:(const String&)extension
>  {
> -    return [extensionToMIME objectForKey:extension];
> +    ASSERT(extension.lower() == extension);
> +    
> +    for (size_t i = 0; i < mimeTypes.size(); ++i) {
> +	   const MimeClassInfo& mimeClassInfo = mimeTypes[i];
> +	   
> +	   for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) {

Diito.

…
> +    return NO;

I doubt that clang++ would allow returning NO from an (NSString *) method.
Please return nil.