[webkit-reviews] review granted: [Bug 40894] Move the NSBundle ivar to WebPluginPackage : [Attachment 59217] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 20 15:02:27 PDT 2010
mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 40894: Move the NSBundle ivar to WebPluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40894
Attachment 59217: Patch
https://bugs.webkit.org/attachment.cgi?id=59217&action=review
------- Additional Comments from mitz at webkit.org
> + cfBundle = CFBundleCreate(NULL, (CFURLRef)[NSURL fileURLWithPath:path]);
Please change NULL to kCFAllocatorDefault.
> + if (nsBundle == nil) {
Please change this to !nsBundle.
More information about the webkit-reviews
mailing list