[webkit-reviews] review denied: [Bug 15994] REGRESSION: Incomplete repaint of CSS image substitution : [Attachment 51272] Patch and test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 20 09:03:25 PDT 2010


Adam Barth <abarth at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 15994: REGRESSION: Incomplete repaint of CSS image substitution
https://bugs.webkit.org/show_bug.cgi?id=15994

Attachment 51272: Patch and test
https://bugs.webkit.org/attachment.cgi?id=51272&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm sorry to have to r- your patch.  In order to make changes like this the
codebase, you need to socialize your change with folks who can review them.  In
this case, there are only a handful of people who can (or are willing to)
review repainting bugs, mostly because the code is subtle, fragile, and poorly
tested.  If current trends continue, your patch will be up for review
indefinitely, which is bad for the project.  Feel free to renominate your patch
for review (or to post an updated patch) when you've found someone who is
willing and able to review your patch.

Again, my apologies that you're running up against some of the brokenness in
our review system.  Hopefully this won't discourage you from contributing more
patches in the future.


More information about the webkit-reviews mailing list