[webkit-reviews] review denied: [Bug 34945] Improve form validation messages. : [Attachment 50278] Proposed patch (rev.3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 20 08:46:46 PDT 2010


Adam Barth <abarth at webkit.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 34945: Improve form validation messages.
https://bugs.webkit.org/show_bug.cgi?id=34945

Attachment 50278: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=50278&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch has been up for review for too long.  Who's the right person to
review this patch?  Why has it stalled out?  I don't know whether the new
messages are better or worse than the old messages.  Is there a spec for this
stuff?	Something has broken down here.

LayoutTests/fast/forms/script-tests/validationMessage.js:16
 +	     "'The value does not match to a character restriction for this
field.'");
Where do these messages come from?  Are they speced somewhere?


More information about the webkit-reviews mailing list