[webkit-reviews] review granted: [Bug 40453] FrameLoader cleanup: Pull subframe and plugin request functions into a separate class : [Attachment 59117] a relevant patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 40453: FrameLoader cleanup: Pull subframe and plugin request functions into
a separate class
https://bugs.webkit.org/show_bug.cgi?id=40453

Attachment 59117: a relevant patch
https://bugs.webkit.org/attachment.cgi?id=59117&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Wow, that's amazing.  I wish I could see the diff of what you changed in each
function more easily.  In the past, I've done these patches in two steps:

1) In place in FrameLoader.cpp so you can see how the code is changing.
2) Moving the next class to its own file.

In any case, it's crazy how there's practically zero communication from
FrameLoader to SubframeLoader.	Nice patch.

WebCore/ChangeLog:11
 +	    * Android.mk:
Darin would ask you for comments next to each of these entries to explain what
you're doing.  I'm bad at writing those comments too though.

WebCore/WebCore.base.exp: 
 +  __ZNK7WebCore11FrameLoader15containsPluginsEv
I'm surprised you don't need to add the new version of this symbol as an
export.  Please make sure this compiles on Mac before landing.

WebCore/GNUmakefile.am:1424
 +	WebCore/loader/SinkDocument.h \
Bad indent.  Please fix before landing.