[webkit-reviews] review denied: [Bug 40878] Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. : [Attachment 59185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 19 05:49:31 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 40878: Speech Input Patch 0: Added compilation argument to conditionally
compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

Attachment 59185: Patch
https://bugs.webkit.org/attachment.cgi?id=59185&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
* You need to update WebKit2/Configurations/FeatureDefine.xcconfig.

WebKit/chromium/features.gypi:56
 +	    'ENABLE_INPUT_SPEECH=0',
Please enable by default in order that buildbots can check compilation.
Enabling INPUT_SPEECH here doesn't mean Chromium/Chrome browser have
INPUT_SPEECH.


More information about the webkit-reviews mailing list