[webkit-reviews] review granted: [Bug 40767] DOM storage should delete databases when they are empty. : [Attachment 59081] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted hans at chromium.org's request for
review:
Bug 40767: DOM storage should delete databases when they are empty.
https://bugs.webkit.org/show_bug.cgi?id=40767

Attachment 59081: Patch
https://bugs.webkit.org/attachment.cgi?id=59081&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Looks good to me....2 double-checking type questions tho...


WebCore/storage/StorageAreaSync.cpp:421
 +	    m_database.close();
Are we super extra ultra sure that there's no way the database can be used
after it's closed?  I almost wondr if we should make it an OwnPtr and null it
out here so that if we do try to use it later we crash.

WebCore/storage/StorageAreaSync.cpp:403
 +	if (!m_database.isOpen())
When can this happen?  Only if it was never opened or something?