[webkit-reviews] review denied: [Bug 40854] JSC bindings for Image Resizer API : [Attachment 59165] Patch 2: JSC bindings

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Sterling Swigart
<sswigart at google.com>'s request for review:
Bug 40854: JSC bindings for Image Resizer API
https://bugs.webkit.org/show_bug.cgi?id=40854

Attachment 59165: Patch 2: JSC bindings
https://bugs.webkit.org/attachment.cgi?id=59165&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm pretty sure you can create these bindings without any extra code.  If you
have trouble, you should ask dumi.

WebCore/ChangeLog:59
 +  2010-06-18	Sterling Swigart  <sswigart at google.com>
You have two ChangeLogs in this patch.

WebCore/bindings/js/JSCustomImageResizerErrorCallback.cpp:47
 + 
JSCustomImageResizerErrorCallback::JSCustomImageResizerErrorCallback(JSObject*
callback, JSDOMGlobalObject* globalObject)
We should be able to auto-generate these callbacks now.  There are some
examples in the database bindings.

WebCore/html/HTMLImageElement.idl:56
 +	    [Custom] void webkitGetImage(in DOMString mimeType, in
ImageResizerSuccessCallback successCallback, [Optional] in
ImageResizerErrorCallback errorCallback, [Optional] in ResizeOptions options)
This shouldn't be custom.