[webkit-reviews] review granted: [Bug 40079] [Qt] Support evaluateScriptInIsolatedWorld() : [Attachment 57690] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 40079: [Qt] Support evaluateScriptInIsolatedWorld()
https://bugs.webkit.org/show_bug.cgi?id=40079

Attachment 57690: Patch
https://bugs.webkit.org/attachment.cgi?id=57690&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKit/qt/Api/qwebframe.cpp:1380
 +	    JSC::JSValue v =
d->frame->script()->executeScriptInWorld(scriptWorld->world(), scriptSource,
true).jsValue();
Why not use the |proxy| local variable here?

WebKit/qt/Api/qwebframe.cpp:1381
 +	    int distance = 0;
Move this below the if?

WebKit/qt/Api/qwebscriptworld.cpp:35
 +    d = new QWebScriptWorldPrivate(ScriptController::createWorld());
Bad indent

WebKit/qt/Api/qwebscriptworld.h:45
 +  private:
Why the second private declaration?

WebKit/qt/Api/qwebscriptworld_p.h:35
 +	}
Maybe add a blank line after this { } and the next?  Not sure what the style
here is supposed to be.