[webkit-reviews] review granted: [Bug 35350] DumpRenderTree should allow tests with modal dialogs : [Attachment 58829] Patch to add a showModalDialog support for DumpRenderTree on Mac.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Prasad Tammana
<prasadt at chromium.org>'s request for review:
Bug 35350: DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Attachment 58829: Patch to add a showModalDialog support for DumpRenderTree on
Mac.
https://bugs.webkit.org/attachment.cgi?id=58829&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if PLATFORM(MAC)

While the need for this may be specific to the Mac, I think the concept can
exist cross platform. We could use a less specific name for the function, but I
suggest we have an empty function on other platforms rather than not function
at all. In the future it could make it easier to write tests. We don’t want a
long term strategy that adds something that’s only for one platform.

I’m going to say it’s OK to land this test as-is, but I don’t completely agree
with every aspect of the approach here. Disabling tests that are expected to
fail is not the best way to deal with them, and there’s a lot of test disabling
here. I also don’t like patches with promises for the future in them.

I don’t understand what the 10.2.2 tests have to do with showModalDialog.