[webkit-reviews] review granted: [Bug 40430] [Chromium] Plumbing for top-level frame names : [Attachment 59131] Reuploaded patch so it can go through EWS again after DEPS roll.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 40430: [Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

Attachment 59131: Reuploaded patch so it can go through EWS again after DEPS
roll.
https://bugs.webkit.org/attachment.cgi?id=59131&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebFrame.h:108
 +	// frame name unique within the hierarchy (see
FrameTree::uniqueChildName()
nit: let's avoid references to WebCore implementation details in the
WebKit API headers.  I'm concerned that these comments will not be
maintained if someone renames WebCore types.

otherwise, LGTM