[webkit-reviews] review denied: [Bug 40849] Add LayoutTest to ensure resources within <noscript> are not preloaded : [Attachment 59144] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40849: Add LayoutTest to ensure resources within <noscript> are not
preloaded
https://bugs.webkit.org/show_bug.cgi?id=40849

Attachment 59144: Patch
https://bugs.webkit.org/attachment.cgi?id=59144&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This might need to be landed by hand because of the empty file.

LayoutTests/fast/preloader/noscript.html:13
 +	<img src=resources/image1.png>
You need to use unique file names to ensure that these URLs aren't in the
cache.	(We only get the resource response printout when we actually hit the
network.)

LayoutTests/fast/preloader/noscript.html:11
 +  <script src=resources/non-existant.js></script>
Also, you should add the document.write("<plaintext>") inline script here to
ensure that we're actually seeing the preloader in action.  The way this test
is written currently, we'll pass without a preloader or if the preloader skips
both.

LayoutTests/fast/preloader/noscript.html:15
 +  <img src=resources/image2.png>
Also, feel free to use double-quoted attributes or whatever so we have some
more coverage of the preload scanner's tokenizer.