[webkit-reviews] review denied: [Bug 40593] Add BlobBuilder.idl to expose BlobBuilder interface : [Attachment 59045] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 40593: Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

Attachment 59045: Patch
https://bugs.webkit.org/attachment.cgi?id=59045&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
I think you also need to update rebaseline test results for
win/qt/gtk/chromium, like
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt.

WebCore/ChangeLog:61
 +	    Add BlobBuilder.idl to expose BlobBuilder interface
Please also mention the link to the BlobBuilder definition in the FileWriter
spec in the ChangeLog.

Also, I do not see any change to V8 bindings and gyp. Are you planning to add
it later? If so, make sure you land both patches at the same time.

WebCore/bindings/js/JSBlobBuilderCustom.cpp:52
 +		String endings = "";
I think we can use the default empty string.

WebCore/html/BlobBuilder.idl:36
 +	    Blob getBlob(in [ConvertUndefinedOrNullToNullString] DOMString
contentType);
Do we need to add Optional here?