[webkit-reviews] review granted: [Bug 40834] Web Inspector: Implement 'heapSnapshot' in InspectorController. : [Attachment 59114] lint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 18 08:42:44 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 40834: Web Inspector: Implement 'heapSnapshot' in InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=40834

Attachment 59114: lint
https://bugs.webkit.org/attachment.cgi?id=59114&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/bindings/js/ScriptProfiler.h:42
 +	static void heapSnapshot() { }
Please rename it for consistency with other code to takeHeapSnapshot.

WebCore/bindings/v8/ScriptProfiler.h:46
 +	static void heapSnapshot();
Please make sure there is a bug about heap snapshotting in JSC.


More information about the webkit-reviews mailing list