[webkit-reviews] review requested: [Bug 40607] Implement the sync DB API in workers : [Attachment 59095] patch #2: Add the SQLException class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 18 04:30:10 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 59095: patch #2: Add the SQLException class
https://bugs.webkit.org/attachment.cgi?id=59095&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
patch #2 should be ready for another look.

Fixed the copyright header.

Fixed the expectations of the failing tests on Mac + the expectations for those
tests on all other ports that I could find.

The patch passes all tests on Mac; a whole bunch of tests fail in the Qt port,
but none of them seems related to this patch (most of them are in css1/,
editing/ and fast/dom/Geolocation/ -- maybe I didn't pass in some flags?).


More information about the webkit-reviews mailing list