[webkit-reviews] review requested: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 59084] patch - Upstreamed DevTools for Chromium DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 18 02:05:24 PDT 2010


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558

Attachment 59084: patch - Upstreamed DevTools for Chromium DRT
https://bugs.webkit.org/attachment.cgi?id=59084&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
First version, tested under Windows (running LayoutTests/inspector).

I'm unsure about the modification to WebKit.gyp (adding include dir for header
generated from resources), i.e., whether to really put that there, and for
which platforms.

Difference to test shell version: on showDevTools() the test shell version
instantiated a separate TestShell instance using weak pointers.
This doesn't seem to be necessary for the DRT implementation (using a single
TestShell instance and a simple WebViewHost* instead).


More information about the webkit-reviews mailing list