[webkit-reviews] review granted: [Bug 40663] Modernize SVG Text code, following the HTML design : [Attachment 59076] Updated patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 18 01:05:10 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 40663: Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663
Attachment 59076: Updated patch v2
https://bugs.webkit.org/attachment.cgi?id=59076&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
WebCore/rendering/SVGRootInlineBox.cpp:53
+ FloatRect boundingBox = boxRenderer->repaintRectInLocalCoordinates();
forgto to mention this boundingBox. -> repaintRect
Just fix this name and i'm fine with it. You moved the LayoutTest results out
now?
More information about the webkit-reviews
mailing list