[webkit-reviews] review denied: [Bug 40746] WebGLShader now keeps track of its shader type : [Attachment 59015] Added accessor, and made other code style changes as requested

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 40746: WebGLShader now keeps track of its shader type
https://bugs.webkit.org/show_bug.cgi?id=40746

Attachment 59015: Added accessor, and made other code style changes as
requested
https://bugs.webkit.org/attachment.cgi?id=59015&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>  WebGLShader::WebGLShader(WebGLRenderingContext* ctx,
GraphicsContext3D::WebGLEnumType type)
> -    : CanvasObject(ctx)
> +    : CanvasObject(ctx), m_shaderType(type)

The ", m_shaderType(type)" should be on its own line.


This change is also missing a ChangeLog.  Please read
http://webkit.org/coding/contributing.html for more information on how to do
this.