[webkit-reviews] review denied: [Bug 40430] [Chromium] Plumbing for top-level frame names : [Attachment 59051] Patch that removes clearName()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 17 21:27:26 PDT 2010
David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 40430: [Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430
Attachment 59051: Patch that removes clearName()
https://bugs.webkit.org/attachment.cgi?id=59051&action=review
------- Additional Comments from David Levin <levin at chromium.org>
The build failure is real.
You need to change 'chromium_rev' in WebKit/chromium/DEPS to avoid it.
If you do it in this patch, the build will still fail because ews doesn't do
another update-webkit --chromium (aka gclient sync) after applying the patch,
so it is nice to do the DEPS roll as a separate patch to ensure that your patch
builds correctly.
More information about the webkit-reviews
mailing list