[webkit-reviews] review granted: [Bug 40132] AX: presentational role needs to be inherited by required elements : [Attachment 58905] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 19:24:46 PDT 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 40132: AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

Attachment 58905: Patch
https://bugs.webkit.org/attachment.cgi?id=58905&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
WebCore/accessibility/AccessibilityRenderObject.cpp:3059
 +	DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, listItemParents, ());
This static local should be defined within the scope of the switch statement
below so it's only created when it's needed.

WebCore/accessibility/AccessibilityRenderObject.cpp:3065
 +	case ListMarkerRole:
The static local variable should be defined here.

r=me


More information about the webkit-reviews mailing list