[webkit-reviews] review granted: [Bug 39041] Move the code that should be shared by sync and async DBs to a separate class : [Attachment 58769] patch #4: sync and async DB APIs should be enabled/disabled at runtime by the same flag
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 17 17:02:38 PDT 2010
Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 39041: Move the code that should be shared by sync and async DBs to a
separate class
https://bugs.webkit.org/show_bug.cgi?id=39041
Attachment 58769: patch #4: sync and async DB APIs should be enabled/disabled
at runtime by the same flag
https://bugs.webkit.org/attachment.cgi?id=58769&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Great! A couple minor comments.
WebCore/storage/AbstractDatabase.cpp:36
+ static bool isDatabaseAvailable = true;
I forget how the webkit-dev thread turned out. g_isDatabaseAvailable? Not
sure.
WebCore/workers/WorkerContext.cpp:297
+ ec = SECURITY_ERR;
Security Error?
More information about the webkit-reviews
mailing list