[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 59038] Switch to JS_EXPORTED_SYMBOL, various style and port fixes

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 59038: Switch to JS_EXPORTED_SYMBOL, various style and port fixes
https://bugs.webkit.org/attachment.cgi?id=59038&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Now all the JS internal exports are controlled using a single define,
JS_EXPORTED_SYMBOL. The rest of the changes from the last patch are all fixes
for build and style bot problems. 

To me, most of the remaining style issues look like either false alarms or
really issues that should have a separate bug filed. (e.g. the warnings about
DEFINE_GLOBAL, are those legit?)

I've made sure the Mac port builds, and addressed the GTK issue I saw on the
EWS bot. Hopefully these changes will fix the Win build as well, but if not,
how do I get to the actual files that have the compilation errors for the Win
EWS bot?