[webkit-reviews] review denied: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 54927] Updated version of the patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 54927: Updated version of the patch
https://bugs.webkit.org/attachment.cgi?id=54927&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Looks pretty close.  There's one bogus code section though:  The offsetX /
offsetY computation that just loops up through the parent ScrollViews. There's
more complexity to converting to window coordinates than just adding in offsets
like that.  Fortunately you can just use contentsToWindow on the rect to
convert it.  This will work in the presence of transforms, unlike the code you
wrote.