[webkit-reviews] review granted: [Bug 40608] [chromium]Refactor input method related APIs. : [Attachment 58757] Fix code style.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 17 10:20:31 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Su
<suzhe at chromium.org>'s request for review:
Bug 40608: [chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608
Attachment 58757: Fix code style.
https://bugs.webkit.org/attachment.cgi?id=58757&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebTextInputType.h:47
+ // TODO(suzhe): Add more text input types when necessary, eg. Number,
nit: In WebKit style, use FIXME: instead of TODO(suzhe):
WebKit/chromium/src/WebViewImpl.cpp:1369
+ // TODO(suzhe): Support more text input types when necessary, eg.
Number,
same nit about FIXME: instead of TODO(suzhe):
More information about the webkit-reviews
mailing list