[webkit-reviews] review denied: [Bug 40675] Web Inspector: native serialization support in the bindings for WebInspector. : [Attachment 58993] [patch] fourth iteration.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 17 07:56:57 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 40675: Web Inspector: native serialization support in the bindings for
WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=40675
Attachment 58993: [patch] fourth iteration.
https://bugs.webkit.org/attachment.cgi?id=58993&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/bindings/v8/ScriptCallStack.cpp:102
+ if (context.IsEmpty())
You don't need this check because of the one above. Please remove.
WebCore/bindings/v8/ScriptCallStack.cpp:104
+ v8::HandleScope scope;
This line should go before v8::Context::GetCurrent() call which returns a local
handle.
r- for that, otherwise looks good.
More information about the webkit-reviews
mailing list