[webkit-reviews] review denied: [Bug 40675] Web Inspector: native serialization support in the bindings for WebInspector. : [Attachment 58975] [patch] second iteration

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 40675: Web Inspector: native serialization support in the bindings for
WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=40675

Attachment 58975: [patch] second iteration
https://bugs.webkit.org/attachment.cgi?id=58975&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/WebCore.gyp/WebCore.gyp:613
 +		'../inspector/CodeGeneratorInspector.pm',
Can we put this to inspector/scripts/ the same way as with bindings?

WebCore/bindings/scripts/generate-bindings.pl:59
 +  #die('Must specify IDL search path.') unless @idlDirectories;
Remove this line?

WebCore/bindings/v8/ScriptCallStack.cpp:100
 +	v8::Context::Scope contextScope(v8::Context::GetCurrent());
There may be no current context. Please add a check.

WebCore/inspector/CodeGeneratorInspector.pm:1
 +  # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann at kde.org>
Please change the license header.

WebCore/CMakeLists.txt:290
 +	inspector/InspectorFrontend2.inspector
Maybe .inspectoridl or something like that, it would be too long though.