[webkit-reviews] review granted: [Bug 40723] Fix paren matching rules for switch/if/while in check-webkit-style script : [Attachment 58908] Proposed patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40723: Fix paren matching rules for switch/if/while in check-webkit-style
script
https://bugs.webkit.org/show_bug.cgi?id=40723

Attachment 58908: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=58908&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. Thanks for this patch!

Please run the style checker for WebCore/*/*.{cpp,h} and examine if there are
no false postives.

WebKitTools/Scripts/webkitpy/style/processors/cpp_unittest.py: 
 +	    self.assert_lint('while (  foo  ) {', 'Should have zero or one
spaces inside'
I think we still want this test. Maybe this case should produce two errors?