[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 58961] Use JS_EXPORT_PRIVATE to export individual symbols

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 58961: Use JS_EXPORT_PRIVATE to export individual symbols
https://bugs.webkit.org/attachment.cgi?id=58961&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
I built wx with this successfully but I wasn't able to build the Win port
because I'm using 2008 and it appears the build scripts for Win don't support
that yet. So probably a good idea to let the bots chew on this patch first. 

Overall, it's a very big patch but almost all of it is just adding
JS_EXPORT_PRIVATE to various symbols. I also include the wx build changes,
though they weren't much. The main thing to look at for review is the config.h
file changes, and for a couple of the classes like String and AtomicString, I
had to add explicit copy constructors and operator= methods so that I could
specify the correct linkage for them. Other than that, I pretty much just
prepended JS_EXPORT_PRIVATE to everything that some other library was asking
for.