[webkit-reviews] review requested: [Bug 40750] Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail : [Attachment 58948] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 16 18:13:03 PDT 2010
Kenneth Russell <kbr at google.com> has asked for review:
Bug 40750: Differences in error reporting for overloaded methods causing
fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750
Attachment 58948: Patch
https://bugs.webkit.org/attachment.cgi?id=58948&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:
Added V8Proxy::throwTypeError() and throwSyntaxError for parity with
JSC::throwTypeError() and throwSyntaxError. Changed CodeGeneratorV8.pm to use
throwTypeError for overload resolution failures. Revised CodeGeneratorJS.pm to
use throwVMTypeError instead of manual call to JSValue::encode. Deleted
now-unnecessary Chromium expectations for fast/canvas/webgl/texImageTest.html.
More information about the webkit-reviews
mailing list