[webkit-reviews] review granted: [Bug 39195] Spatial Navigation: refactor scrollInDirection to work with scrollable content : [Attachment 58787] patch v2

Wed Jun 16 17:08:35 PDT 2010

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 39195: Spatial Navigation: refactor scrollInDirection to work with
scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Attachment 58787: patch v2
https://bugs.webkit.org/attachment.cgi?id=58787&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +++
b/LayoutTests/fast/events/spatial-navigation/snav-only-clipped-overflow-content
.html
> @@ -0,0 +1,77 @@
> +<html>
> +  <!--
> +    This test ensures the content overflow traversal correctness of Spatial
Navigation
> +    algorithm: if an element if clipped overflow in a scrollable container
(e.g. <div>),
> +    scroll-in-direction should happen in the container box.
> +
> +    * Pre-conditions:
> +    1) DRT support for SNav enable/disable.
> +
> +    * Navigation steps:
> +    1) Loads this page, focus goes to "start" automatically.
> +    2) Try to move focus down to the visible focusable element in
> +	  scrollable div.
> +
> +    * Expected results: There should have to a scroll action in the
container
> +    (div) as an attempt to make the clipped overflow node visible and
accessible
> +    via SNav. -->

Don't use SNav as an abbreviation. Out of context, someone might not know what
it means.

r=me