[webkit-reviews] review denied: [Bug 39564] [Qt] DRT Support for setCustomPolicyDelegate : [Attachment 56821] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 39564: [Qt] DRT Support for setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=39564

Attachment 56821: Patch
https://bugs.webkit.org/attachment.cgi?id=56821&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:165
 +  static const char* linkClickedString = "link clicked";
I suggest to leave out these variables. They will be read-write pointers to
read-only memory, causing unnecessary relocations.

WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:174
 +  static const char* navigationTypeToString(NavigationType type)
Instead I suggest to return the strings inline here, like return "form
submitted";